Question [Tag Plugin] Feedback

[Bochardi]

Hello everyone,

This is my first time ever making a plugin and first time ever really touching Java. With that being said I was wondering if any one could give any recommendations on my plugin, It is a simple tag plugin, this is not a release but rather me requesting constructive criticism to help me in my journey of writing good code, I know some areas may be sloppy, But i am still learning the overall Java and Minecraft plugin development as I was coding this. Anyways here is a link to the repo feedback will be appreciative, have a wonderful day.

https://github.com/vinzoperez/Tag-Minigame-Plugin/tree/master

 

[mbaxter]

It looks like you have the plugin set to private! Cannot view.

 

[Bochardi]

It looks like you have the plugin set to private! Cannot view.

Ack! That’s Embarrassing should be all set now

 

[mbaxter]

Some feedback:

• Don't commit the target directory to your git repo.
• You're building against 1.21.4 but have only 1.21 in plugin.yml's api-version. You can set it to '1.21.4'
• Commands typically are lowercase. "Tag" is jarring, in that way. I don't think it really impacts anything, though.
• Command class:
  • I think you mean to test for arg length being 0, not >1, for displaying help.
  • The established "Component message;" is strange. Just create the variable, when necessary, in the code and sometimes you don't even need to! Like, you could just do sendMessage(MiniMessage.deserialize(stuff))
• and then I ran out of time

 

[Bochardi]

Some feedback:

• Don't commit the target directory to your git repo.
• You're building against 1.21.4 but have only 1.21 in plugin.yml's api-version. You can set it to '1.21.4'
• Commands typically are lowercase. "Tag" is jarring, in that way. I don't think it really impacts anything, though.
• Command class:
  • I think you mean to test for arg length being 0, not >1, for displaying help.
  • The established "Component message;" is strange. Just create the variable, when necessary, in the code and sometimes you don't even need to! Like, you could just do sendMessage(MiniMessage.deserialize(stuff))
• and then I ran out of time

Thank you so much for your feedback!
I really don't know what I was thinking for the plugin.yml command using uppercase lol.

Glad to hear from you

 

[Leander]

You're using inconsistent formatting styles with your curly braces, sometimes on a newline, sometime on the same line. Just a nitpick tho

 

[Bochardi]

You're using inconsistent formatting styles with your curly braces, sometimes on a newline, sometime on the same line. Just a nitpick tho

I see what you mean, I am still debating if i should use same line or new line? What do you prefer?

Just wanna make it so everyone can read it and understand it with no confusion, if there is a modern format style i should aim for let me know!

 

[stefvanschie]

With Java, K&R style (opening brace on the same line) is generally the most commonly used. If you don't care which style you use, I'd recommend sticking with that one, since other Java programmers will be more familiar with it.

 

[Leander]

Most IDEs also have a formatting button that I would hit every so often or configure it to format on save