Paper 1.8.8 crash

[katanya04]

Hi. First of all sorry if this is not the correct place to post a Paper crash, I'm didn't see any place specifically for that. I hope is it ok here.
Anyways, my server is crashing on startup. It starts, stays "alive" for a few seconds, and then paper crashes. There's no previous plugin crash whatsoever or any such errors. I do not see any plugin name in the stack trace, so I suppose this is a Paper issue. The crash stack trace is attached to this message as a txt file.

 

[electronicboy]

1.8 hasn't been supported in years. Your server took too long to tick, newer versions of the software print out more info when this happens to make it possible to diagnose what occurred. That looks like an issue we patched years ago relating to spigot parsing stuff sent by the client too early, allowing malicious actors to crash servers by sending complex books to them or something.

 

[katanya04]

1.8 hasn't been supported in years. Your server took too long to tick, newer versions of the software print out more info when this happens to make it possible to diagnose what occurred. That looks like an issue we patched years ago relating to spigot parsing stuff sent by the client too early, allowing malicious actors to crash servers by sending complex books to them or something.

Yes it seems there was a bad guy trying to send weird packets, so it is probably that.
I didn't know paper 1.8.8 wasnt supported, I thought at least security issues would get fixed... if I were to fix this issue and do a pull request would you guys accept it? Or is this version completely abandoned?
In either case, thank you for your reply.

 

[electronicboy]

No, we do not accept PRs to 1.8, we do not have the capacity or desire to maintain a running on 10 year old codebase, especially after investing as much time as we have into our modern tooling which makes the codebase so much nicer to deal with.

 

[katanya04]

No, we do not accept PRs to 1.8, we do not have the capacity or desire to maintain a running on 10 year old codebase, especially after investing as much time as we have into our modern tooling which makes the codebase so much nicer to deal with.

I understand.
Supposing the crash was because of malicious packets using complex book as you said on the first comment, would you know in which version/commit was it fixed? How could I search for this specific bugfix?

 

[mbaxter]

I understand.
Supposing the crash was because of malicious packets using complex book as you said on the first comment, would you know in which version/commit was it fixed? How could I search for this specific bugfix?

The version to run is 1.21 - doesn't have this issue and is currently supported by us.

 

[katanya04]

The version to run is 1.21 - doesn't have this issue and is currently supported by us.

Yes I understand the best solution is to run on currently supported software instead of a decade old one. I would like to know how feasible would it be for me to fix this specific bug on 1.8.8 Paper. And with that knowledge, ponder which decision to make

 

[mbaxter]

We don't really give out specifics on exploits. You'll need to work backwards from your crashes.

 

[katanya04]

We don't really give out specifics on exploits. You'll need to work backwards from your crashes.

Wouldn't it there be a specific commit for this bug? Is commit history private?

 

[mbaxter]

Commit history is public. Have fun!